-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] fix(node): Fix output of iota validator make-validator-info #4571
base: develop
Are you sure you want to change the base?
Conversation
…r transport string
…e/fix-make-validator-info
…e/fix-make-validator-info
I pushed some minor improvements! |
@DaughterOfMars |
Some of it will still run, but big things won't. If you want to keep running all the CI, marking this as a draft in the title is fine. |
✅ Vercel Preview Deployment is ready! |
Fyi. Will try to solve the failing checks and open a new PR with signed commits. |
You can sign the commits all at once with this command, and force push them, if you'd prefer!
|
Description of change
Changing
primary_address
to use tcp instead of udp and adding ip4/ip6/dns support for the output filevalidator.info
ofiota validator make-validator-info
cmd. More info also here: #4437Links to any relevant issues
Fixes: #4437 Fix output of iota validator make-validator-info
Type of change
How the change has been tested
Check
validator.info
after each time running the cmds below, make sureprimary_address
uses tcp instead of udp and all addresses use this multiaddr format ip4/ip6/dns correctly depending on the address input of the cmd.Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.